[buddypress-trac] [BuddyPress Trac] #5603: Posting a new Activity causes activity-loop.php scope filters to be removed

[buddypress-trac]

#5603: Posting a new Activity causes activity-loop.php scope filters to be removed
-------------------------------------------------+-------------------------
 Reporter:  xyhavoc                              |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  Activity                             |  Review
 Severity:  major                                |     Version:  2.0
 Keywords:  reporter-feedback has-patch 2nd-     |  Resolution:
  opinion                                        |
-------------------------------------------------+-------------------------

Comment (by imath):

 Replying to [comment:11 boonebgorges]:
 > What's the natural situation where this will happen? When *should*
 `$last_recorded = 0`? When an activity stream is empty? (Just trying to be
 clear on why we'd try to preserve this `else` condition.)
 in buddypress.js, i init last_date_recorded to 0. And if there's a
 timestamp class (needed by the heartbeat feature) in the first displayed
 activity, then last_date_recorded takes the corresponding timestamp value.
 So if $last_recorded is empty it means we're on the user's profile
 activity page as no timestamp class are added in this part.

 I really think the else condition is only usefull for the user's profile
 member's header. Because when a user is posting an update from his
 profile, the content of this update is also "copied" into
 {{{
 <div id="latest-update">

         <?php bp_activity_latest_update( bp_displayed_user_id() ); ?>

 </div>
 }}}
 So using the "else" part {{{array( 'include' => $activity_id )}}}, we make
 sure there can be only one latest_update in member's header

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5603#comment:12>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac