[buddypress-trac] [BuddyPress Trac] #5399: Review metadata functions for irregularities

buddypress-trac noreply at wordpress.org
Fri Mar 14 00:15:42 UTC 2014


#5399: Review metadata functions for irregularities
--------------------------+---------------------------
 Reporter:  boonebgorges  |       Owner:  boonebgorges
     Type:  enhancement   |      Status:  assigned
 Priority:  normal        |   Milestone:  2.0
Component:  Core          |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  2nd-opinion   |
--------------------------+---------------------------

Comment (by boonebgorges):

 In [changeset:"8130"]:
 {{{
 #!CommitTicketReference repository="" revision="8130"
 Don't trim whitespace from $meta_value param in _delete_meta() functions

 The $meta_value parameter of BP's delete_meta() functions allows
 developers to
 limit deletion to rows that match both the $meta_key *and* the specified
 $meta_value. However, most of BP's delete_meta() functions have always had
 a
 quirk whereby the $meta_value was run through trim() before matching
 against
 the values in the database. This had the unacceptable side effect that
 passing
 a $meta_value of '  foo  ' would delete rows with the value 'foo', but
 *not*
 the value '  foo  '!

 This changeset reverses the behavior, and modifies the relevant unit
 tests.

 See #5399
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5399#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list