[buddypress-trac] [BuddyPress Trac] #5450: Problem with groups in buddypress when a comment has more than five direct answers

[buddypress-trac]

#5450: Problem with groups in buddypress when a comment has more than five direct
answers
-------------------------------------------------+-------------------------
 Reporter:  dmuneras                             |       Owner:
     Type:  defect (bug)                         |      Status:  closed
 Priority:  high                                 |   Milestone:  Awaiting
Component:  Theme                                |  Review
 Severity:  normal                               |     Version:  1.9.1
 Keywords:  needs-patch reporter-feedback dev-   |  Resolution:  fixed
  feedback 2nd-opinion                           |
-------------------------------------------------+-------------------------
Changes (by dmuneras):

 * keywords:  needs-patch reporter-feedback => needs-patch reporter-feedback
     dev-feedback 2nd-opinion
 * resolution:   => fixed
 * status:  new => closed
 * component:  Groups => Theme


Comment:

 Thanks for your answer

 I  already found the problem. Some themes like Bounce and Buddy override
 the variable:

 Bounce: '<<bounce dir>>/lib/buddypress/functions-buddypress.php'

 {{{
 // Add words that we need to use in JS to the end of the page so they can
 be translated and still used
 if (!function_exists( 'bp_dtheme_enqueue_scripts')) {
         function bp_dtheme_enqueue_scripts() {
                 $params = array(
                         'my_favs'           => __('My Favorites',
 'buddypress'),
                         'accepted'          => __('Accepted',
 'buddypress'),
                         'rejected'          => __('Rejected',
 'buddypress'),
                         'show_all_comments' => __('Show all comments for
 this thread', 'buddypress'),
                         'show_all'          => __('Show all',
 'buddypress'),
                         'comments'          => __('comments',
 'buddypress'),
                         'close'             => __('Close', 'buddypress'),
                         'view'              => __('View', 'buddypress'),
                         'mark_as_fav'       => __('Favorite',
 'buddypress'),
                         'remove_fav'        => __('Remove Favorite',
 'buddypress')
                 );
                 wp_localize_script('dtheme-ajax-js', 'BP_DTheme',
 $params);
         }
         add_action('wp_enqueue_scripts', 'bp_dtheme_enqueue_scripts');
 }
 }}}

 At least it works for us.

 Could you explain to me why buddypress defines BP_DTheme in two different
 functions: bp_dtheme_enqueue_scripts and enqueue_scripts?

 Best regards,
 Daniel.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5450#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac