[buddypress-trac] [BuddyPress Trac] #5374: Administation screen to manage signups

buddypress-trac noreply at wordpress.org
Tue Mar 4 17:24:28 UTC 2014


#5374: Administation screen to manage signups
-------------------------------------------------+------------------
 Reporter:  imath                                |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  high                                 |   Milestone:  2.0
Component:  Members                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  2nd-opinion has-patch needs-testing  |
-------------------------------------------------+------------------

Comment (by DJPaul):

 I have reviewed some of the patch:

 * In the changes to`bp_update_to_2_0()`, why do we need to strip
 whitespace from `$user_login`? Is this something WPMU does when adding to
 the `signups` table?
 * `delete_user_option( $signup->ID, 'capabilities' );` -- this looks
 dangerous. Is this really the best way just to hide this user from the
 regular user list until the account is activated? What happens if an admin
 edits a user's WP profile before the user activates their account? I think
 would WP re-build these options.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5374#comment:18>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list