[buddypress-trac] [BuddyPress Trac] #4785: Decouple "visibility" and "access" properties

[buddypress-trac]

#4785: Decouple "visibility" and "access" properties
-------------------------+------------------
 Reporter:  smninja      |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  2.1
Component:  Groups       |     Version:  1.7
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+------------------

Comment (by imath):

 Replying to [comment:31 boonebgorges]:
 > This looks like a very ugly problem, and your proposed solution is very
 ugly too :) It's amazing to me that we're only now discovering this
 problem, given that we've used `bp_core_new_subnav_item()` for
 `BP_Group_Extension` forever.

 I agree about my solution :) I think, we're discovering this problem now
 because, before the group access logic was managed before any nav was set.
 So we were redirected before this could happen.
 `bp_core_new_subnav_item()` seems to mainly be designed for user nav, as,
 if no access, the logged in user is at the end redirected to
 {{{bp_displayed_user_domain()}}}. In case of a group, as we're not seeing
 a user the displayed user id is not set and the redirect url ends up to
 nothing {{{''}}}

 > Can you give details on how to reproduce your problem? I think we need
 to take a deeper look at the root cause instead of writing fixes that are
 too specific.
 No problem, you just need to display a private group being logged in (and
 not a member of it). Then add {{{members}}} at the end of the url. If you
 do it without applying the patch you're redirected to group's home, if you
 do it after, you're redirected to {{{''}}}

 > the current fixes are not designed to solve any problems with core tabs
 It's an enhancement to BP_Group_Extension. I was just hypothesizing that
 it might be possible to apply this to something like the 'members' tab..

 Yes this is a great enhancement for group extensions ;) I think it might
 be not possible unless we can filter core tabs user access argument before
 parent::subnav() is called in BP Groups loader.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4785#comment:33>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac