[buddypress-trac] [BuddyPress Trac] #5701: like_escape() is deprecated as of WP 4.0

[buddypress-trac]

#5701: like_escape() is deprecated as of WP 4.0
--------------------------+------------------
 Reporter:  boonebgorges  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  2.1
Component:  Core          |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------
Changes (by boonebgorges):

 * keywords:   => has-patch


Comment:

 5701.patch adds the proposed `bp_esc_like()` wrapper function, and
 implements throughout BuddyPress. For the most part, this was fairly
 straightforward, though there were a few places where query structure had
 to be rearranged to make sure that strings like `LIKE '%foo%'` weren't
 getting run through `$wpdb->prepare()` again (which would strip the `%`
 marks).

 I've written unit tests for all instances of `like_escape()` that weren't
 already covered (see r8506, r8506), with the exception of those that are
 specific to bbPress 1.x (I don't feel much like figuring out how to
 install bbPress during automated testing).

 I'd like to have a sanity check from another dev that this is the route we
 want to take before committing the changes. As I see it, this is kinda our
 only choice.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5701#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac