[buddypress-trac] [BuddyPress Trac] #5770: Change "commented on the post" to something more agnostic

buddypress-trac noreply at wordpress.org
Sun Jul 20 23:19:04 UTC 2014


#5770: Change "commented on the post" to something more agnostic
-----------------------------+------------------------------
 Reporter:  Prometheus Fire  |       Owner:
     Type:  enhancement      |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Blogs            |     Version:  2.0
 Severity:  normal           |  Resolution:
 Keywords:  dev-feedback     |
-----------------------------+------------------------------
Changes (by Prometheus Fire):

 * keywords:   => dev-feedback
 * type:  defect (bug) => enhancement
 * version:   => 2.0
 * component:  Core => Blogs


Comment:

 I don't know how to submit a patch for review and integration but this is
 the code change I'm talking about:

 bp-blogs/bp-blogs-activity.php line 194:

 Change from
 {{{
 if ( is_multisite() ) {
         $action  = sprintf( __( '%1$s commented on the post, %2$s, on the
 site %3$s', 'buddypress' ), $user_link, $post_link, '<a href="' . esc_url(
 $blog_url ) . '">' . esc_html( $blog_name ) . '</a>' );
  } else {
         $action  = sprintf( __( '%1$s commented on the post, %2$s',
 'buddypress' ), $user_link, $post_link );
         }
 }}}

 Change to:


 {{{
         if ( is_multisite() ) {
                 $action  = sprintf( __( '%1$s commented on: %2$s, on the
 site %3$s', 'buddypress' ), $user_link, $post_link, '<a href="' . esc_url(
 $blog_url ) . '">' . esc_html( $blog_name ) . '</a>' );
         } else {
                 $action  = sprintf( __( '%1$s commented on: %2$s',
 'buddypress' ), $user_link, $post_link );
         }
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5770#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list