[buddypress-trac] [BuddyPress Trac] #5357: 404 when clicking "Request Membership" within single group page

[buddypress-trac]

#5357: 404 when clicking "Request Membership" within single group page
-------------------------------------+--------------------
 Reporter:  mgibbs189                |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  low                      |   Milestone:  2.0
Component:  Groups                   |     Version:  1.9.1
 Severity:  minor                    |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+--------------------
Changes (by imath):

 * keywords:  has-patch => has-patch needs-testing
 * priority:  normal => low
 * component:  Core => Groups
 * severity:  normal => minor
 * milestone:  Awaiting Review => 2.0


Comment:

 Thanks for your feedback and patch @mgibbs189

 As i've said here #5140 i've managed to reproduce the trouble.

 1/ There's a javascript issue for sure
 2/ While regular users are still reaching the site.url/groups/groupslug
 /request-membership/, a superadmin gets a 404.

 Trouble starts in bp-groups/bp-groups-loader.php because the screen
 function is not available as there's this check {{{! bp_current_user_can(
 'bp_moderate' )}}} around line 422

 I'll check @mgibbs189's patch and i think we should also do something for
 part 2 of the bug to avoid the 404 in case the loggedin user is a
 superadmin.

 As superadmins can see all groups content, they don't need to be part of
 the group, but i agree it should be fixed.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5357#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac