[buddypress-trac] [BuddyPress Trac] #5333: new_blog_post activity items not deleted when blog post is deleted

[buddypress-trac]

#5333: new_blog_post activity items not deleted when blog post is deleted
--------------------------+--------------------
 Reporter:  henry.wright  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  2.0
Component:  Activity      |     Version:  1.9.1
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+--------------------

Comment (by boonebgorges):

 DJPaul - Thanks for the patch.

 >  but probably nicer to integrate into a
 bp_blogs_catch_published_post()-type wrapper

 Yup, the more possibilities I'm seeing, the more I'm thinking it should
 all be centralized.

 See 5333.02.patch.

 In other words:
 a. Do nothing if this is just an edit.
 b. If the post is being published (ie, transitioned to 'publish' from a
 non-'publish' status), post a new activity item. (This reproduces the
 existing bp_blogs_catch_published_post().)
 c. If the post is being unpublished, delete the activity item. DJPaul,
 your patch only deletes for publish->trash and publish->draft, but I think
 henry.wright is correct that we should account for other cases as well.
 Was your original concern about custom statuses? Maybe we can just extend
 our whitelist.

 > Should the same housekeeping be done for blog post comments?

 Yes. Let's wait until we get it how we want it for posts, and then we can
 port it to comments.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5333#comment:15>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac