[buddypress-trac] [BuddyPress Trac] #5436: BP_Core shouldn't run on 'bp_setup_components'

[buddypress-trac]

#5436: BP_Core shouldn't run on 'bp_setup_components'
--------------------------+-----------------------------
 Reporter:  r-a-y         |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Core          |    Version:
 Severity:  normal        |   Keywords:
--------------------------+-----------------------------
 In bp-core-loader.php, the `BP_Core` class is responsible for includng all
 BP component code into WordPress.

 The problem is we load up the `BP_Core` class on 'bp_setup_components' as
 well as any other components on the same action.

 What we need to do is load `BP_Core` ''before'' `'bp_setup_components'` so
 the other component's priority settings on 'bp_setup_components' will take
 effect.

 Attached patch runs `BP_Core` on `'bp_loaded'` at priority 0 since this
 runs before 'bp_setup_components' and fixes how `'bp_setup_components'` is
 intended to run.

 Also had to fix an issue with the members component's `default_component`.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5436>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac