[buddypress-trac] [BuddyPress Trac] #5432: Members search & WP 3.9 since WP changeset 27257

[buddypress-trac]

#5432: Members search & WP 3.9 since WP changeset 27257
--------------------------+-----------------------------------
 Reporter:  imath         |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  2.0
Component:  Members       |    Version:
 Severity:  normal        |   Keywords:  has-patch 2nd-opinion
--------------------------+-----------------------------------
 With latest WordPress trunk, if you perform a member search, this will
 trigger a warning error and will break the search.

 Reason is the use of {{{mysql_real_escape_string}}} to escape the
 {{{search_terms}}} in {{{BP_User_Query}}}. Seems the mysql connexion is
 not available when using this function, so the second argument is
 necessary.

 We could use {{{$wpdb->_real_escape()}}} instead. But i think,
 {{{esc_sql()}}} can also do the job.

 BP_Signup::get (#5374) will also be concerned.

 Finally {{{mysql_real_escape_string}}} is
 [http://fr2.php.net/manual/en/function.mysql-real-escape-string.php
 deprecated as of PHP 5.5.0]

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5432>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac