[buddypress-trac] [BuddyPress Trac] #5395: Notify everyone that comments on an activity update of new comments

[buddypress-trac]

#5395: Notify everyone that comments on an activity update of new comments
-------------------------+------------------------------
 Reporter:  terraling    |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Activity     |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  2nd-opinion  |
-------------------------+------------------------------
Changes (by boonebgorges):

 * keywords:   => 2nd-opinion
 * component:  Core => Activity


Comment:

 This is a pretty cool idea.

 I worked up a more usable patch. I haven't really tested it much, so ymmv.
 But it shows the general strategy I'd take. See 5395.patch.

 - created a separate function `bp_activity_get_thread_participants()` to
 get the participants. I was able to do this without introducing new SQL
 queries.
 - Adjust the logic in the existing
 `bp_activity_new_comment_notification()` for complete backpat.

 There are a couple aspects I'm unsure about, or need more work.

 1. I'm using the single 'notification_activity_new_reply' setting for all
 notification types. We might want something more fine-grained, in which
 case we'd need another setting section.
 2. This is going to result in lots more email for people in some cases. We
 might want per-thread muting. Muted topics could be stored in usermeta.
 We'd then need to have UI to show whether you're subscribed/not subscribed
 to a given thread. This gets complicated fast (see buddypress-group-email-
 subscription)
 3. In some cases, this could result in sending lots of emails, if threads
 are very long. Not sure how big a problem this is in general. But this'd
 be the first place in BP (to my knowledge) where we attempt to send an
 email to more than a person or two at a time.

 Feedback welcome.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5395#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac