[buddypress-trac] [BuddyPress Trac] #6040: Friendship activity missing

[buddypress-trac]

#6040: Friendship activity missing
------------------------------------+-----------------------
 Reporter:  dontdream               |       Owner:  imath
     Type:  defect (bug)            |      Status:  assigned
 Priority:  normal                  |   Milestone:  2.2
Component:  Friends                 |     Version:  1.1
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+-----------------------

Comment (by r-a-y):

 Thanks imath for pinging me about this ticket.

 Changing the `'just-me'` scope to add in activity that wasn't created by
 that user does not sound like the right way to go about this.

 Here's my idea (feel free to shoot it down!):

 * Change the second `friends_record_activity()` type located
 [https://buddypress.trac.wordpress.org/browser/tags/2.1.1/src/bp-friends
 /bp-friends-activity.php#L239 here] to `'friendship_accepted'` leaving
 `'hide_sitewide'` set to 1.  Yes, we would be bringing back
 `'friendship_accepted'`!
 * We then do a version of imath's additions, but add the
 `'friendship_accepted'` type to the scope args if the user isn't logged-
 in.  See `bp_friends_filter_activity_just_me_scope()` in the patch.
 * A migration script will be needed for the friendship activity itemsif we
 do decide to do this.

 The other stuff in the patch separates the hardcoded scopes from
 `BP_Activity_Activity::get_scope_query_sql()` into separate, filterable
 scopes similar to how the `'friends'` and `'groups'` scopes are separated.
 That way, it would be possible for the friends component to filter the
 `'just-me'` scope to add its special conditions like in the patch.

 I haven't added a migration script or unit tests for this yet because I'm
 not sure if this approach is desired or not.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6040#comment:15>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac