[buddypress-trac] [BuddyPress Trac] #5786: Activity Search Results not Displaying comments with matching terms.

[buddypress-trac]

#5786: Activity Search Results not Displaying comments with matching terms.
--------------------------+----------------------
 Reporter:  marketraisen  |       Owner:
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:
Component:  Activity      |     Version:  2.0
 Severity:  normal        |  Resolution:  invalid
 Keywords:                |
--------------------------+----------------------
Changes (by imath):

 * status:  new => closed
 * resolution:   => invalid
 * milestone:  Awaiting Review =>


Comment:

 hi marketraisen

 Thanks for your feedback. I think it's not a BuddyPress bug but a
 HashBuddy one. In short: This plugin is trying to get a
 {{{$_GET['hash']}}} var that doesn't exist in the url, it should use the
 {{{$_GET['s']}}} one.

 see my suggestion to fix the trouble here:
 https://gist.github.com/imath/5812cf545d54c6364078

 In details:

 The plugin was trying to force the activity stream to use the
 {{{display_comments => true}}} mode when a "hash buddy" search was
 performed. This way comments have their 'own' activities and are not only
 attached to their parents and are part of the search performed by
 BuddyPress. The problem was: as the {{{$_GET['hash']}}} doesn't exist,
 then the query_string is not filtered, then the mode {{{display_comments
 => true}}} is not set, then comments remain attached to their parents
 only, then no results because not in the scope for search.

 So i'd suggest you report the problem to the plugin's author, i'm closing
 this ticket as invalid, but if modemlooper needs some adjustment in this
 area, feel free to reopen.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5786#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac