[buddypress-trac] [BuddyPress Trac] #5807: 'new_member' activity type should not be a xProfile activity type

[buddypress-trac]

#5807: 'new_member' activity type should not be a xProfile activity type
-----------------------------------+------------------
 Reporter:  imath                  |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  2.1
Component:  Activity               |     Version:  1.1
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+------------------
Changes (by imath):

 * version:  1.5 => 1.1


Comment:

 Replying to [comment:2 boonebgorges]:
 > imath, can you please research whether 'new_member' items have always
 been associated with 'xprofile'? Was there ever a time when they were
 associated with 'profile' when xprofile was inactive? (We have at least
 one activity type that does this.)

 Yes: the 'new_avatar' one is associated with 'profile'

 Since r1851 (birth of this type) in version
 [https://buddypress.trac.wordpress.org/browser/tags/1.1/bp-
 xprofile.php#L636 1.1], the 'new_member' has been associated with the
 {{{$bp->profile->id}}} component, meaning it should have always been
 'xprofile'.

 I understand your concern, that's why i thought the
 5807.disable_new_member.patch could be a "not too risky" step for 2.1, and
 then we could review with some more time the other patch for 2.2

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5807#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac