[buddypress-trac] [BuddyPress Trac] #5560: Blog Comment Sync Activity removes Filter and Click-through functionality

[buddypress-trac]

#5560: Blog Comment Sync Activity removes Filter and Click-through functionality
-------------------------------------+--------------------
 Reporter:  mrjarbenne               |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  2.0.1
Component:  Activity                 |     Version:  2.0
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+--------------------

Comment (by r-a-y):

 Just going to revisit the points I mentioned in comment:2:

 (tl:dr - point 2 should be committed, the rest should be bumped)

 '''Point 1 - Action formatting for activity comments associated with blog
 posts'''

 I wanted to reuse our blog comment activity action callback, however this
 technique is a little iffy because if a blog post modifies its title, the
 activity meta (which houses the blog and post's URL and name) for the
 activity comment will not be updated.

 '''Point 2 - Switching the primary link for activity comments associated
 with blog posts to the comment permalink'''

 I think this one is good to go.  But, I think we need to do a better job
 of recording the blog comment's permalink as I don't think our code
 handles comment pagination when re-recording the primary link.

 '''Point 3 - "Comments" dropdown filter'''

 After discussing this issue with mrjarbenne, he brings up a good point
 about the "Comments" dropdown filter.

 In my patch, I switch to filtering only activity comments associated with
 blog posts and not old-school "new_blog_comment" singular entries.
 However, it might be beneficial if the "Comemnts" dropdown option filtered
 both types of comments - "new_blog_comment" entries and activity comments
 associated with blog posts.

 This brings up a larger issue with supporting both types of comment
 systems at the same time.  Right now, if you enable activity stream
 commenting, this disables the recording of separate "new_blog_comment"
 entries.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5560#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac