[buddypress-trac] [BuddyPress Trac] #5586: Add ID to editfield DIV

buddypress-trac noreply at wordpress.org
Fri Apr 25 16:12:23 UTC 2014

#5586: Add ID to editfield DIV
 Reporter:  sooskriszta        |       Owner:
     Type:  enhancement        |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Template Pack      |     Version:
 Severity:  normal             |  Resolution:
 Keywords:  needs-patch close  |

Comment (by hnla):

 Generally with a series of elements such as this, forms, lists etc things
 that repeat often in a loop sense it useful to ensure the main parent has
 a unique token, I'll nearly always  drop a '-1', '-2' in the class list.
 adding a token to the parent is important  - although we are well catered
 for here - as we tend to always hook rules via descendent selectors thus
 one works from the outermost parent  which allows us to easily target the
 children, often seen is the error where parent has no token or tokens only
 on children which causes issues.

 Adding a class 'editfield-1' ought to be sufficient along with existing
 class 'editfield' for generic styles.

 Sidenotes: See underscores in those tokens ought really to be hyphens
 always in tokens. That div editfield would better be marked up as a
 'fieldset' but perhaps that's a matter for template pack to pick up on.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5586#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list