[buddypress-trac] [BuddyPress Trac] #5575: Deleting Users in Manage Signups Leaving Database Entries

[buddypress-trac]

#5575: Deleting Users in Manage Signups Leaving Database Entries
-------------------------------------------------+-------------------------
 Reporter:  aaclayton                            |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  high                                 |   Milestone:  2.0.1
Component:  Administration                       |     Version:  2.0
 Severity:  major                                |  Resolution:
 Keywords:  needs-testing has-patch reporter-    |
  feedback 2nd-opinion                           |
-------------------------------------------------+-------------------------
Changes (by imath):

 * keywords:  needs-patch needs-testing => needs-testing has-patch reporter-
     feedback 2nd-opinion


Comment:

 hi aaclayton

 Thanks for your feedback. Here are the tests i've made. This case is only
 happening on a non multisite config.

 1. On a "clean" configuration : that is to say that the BuddyPress
 registration process has not been altered by another plugin or direct
 manipulation of the database by a user. Deleting a signup '''will also'''
 delete the user.
 2. On a "not clean" configuration : that is to say something happened in
 the database and more precisely, to reproduce your issue, i had to
 manually empty the user meta "activation_key". That is to say the meta key
 exists with no value while the user status is set to 2. Deleting a signup
 '''will not''' delete the user.

 That said :
 I've tested the BuddyPress Pending Activations plugin to make sure the
 fact a user with a user status set to 2 having an empty activation key was
 not related to the way this plugin works. And this plugin seems to do
 things right.
 I've also made other tests :
 3. After test 2. if i go on the user's profile in front end, i'm able to
 delete the user.
 4. i've activated BuddyPress Pending Activations and deleted a signup from
 its interface, it also deleted the user, but not the signup in BuddyPress
 signup management screen which is normal. Once done Deleting the signup
 from there worked.

 The reason a signup is not deleted when using the BuddyPress signups
 management screen :
 When deleting a signup, we check if the username exists to get an eventual
 user_id, if we get this id we then check for the activation_key. This
 "extra security" check is the reason why the user is not deleted. As the
 activation_key is empty it cannot be a key generated by BuddyPress at
 first place.

 I'm attaching 5575.diff to this ticket which removes the activation_key
 check. It would be great if :
 - core team could give me an opinion about it
 - aaclayton could : check the signups that gave him troubles to see if
 they have a corresponding empty "activation_key" user meta. And check if
 applying the patch solves his issue.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5575#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac