[buddypress-trac] [BuddyPress Trac] #5513: Bulk Notifications Management

[buddypress-trac]

#5513: Bulk Notifications Management
---------------------------+------------------
 Reporter:  colabsadmin    |       Owner:
     Type:  enhancement    |      Status:  new
 Priority:  normal         |   Milestone:  2.1
Component:  Notifications  |     Version:  2.0
 Severity:  normal         |  Resolution:
 Keywords:  needs-patch    |
---------------------------+------------------
Changes (by boonebgorges):

 * keywords:   => needs-patch
 * milestone:  Awaiting Review => 2.1


Comment:

 Wow, this is really excellent. If you don't mind rewriting this as a BP
 patch, I think we can definitely look at including it for 2.1. A couple
 comments:

 - For sort, please use a different parameter from 's'. This is used by WP
 and many other plugins for 'search'. Maybe something like
 'notification_type'?
 - For the "not very pretty" component names, you could do something like:
 buddypress()->{$component}->name. We could build a wrapper for this if you
 think it'd be better. Or if you think that notification types should
 register their own names, it might be an even more elegant system.
 - Please use our API-level functions for processing bulk actions, rather
 than direct SQL queries. (Especially because you aren't sanitizing the
 input correctly :) ). Check out
 https://buddypress.trac.wordpress.org/browser/tags/1.9.2/bp-notifications
 /bp-notifications-functions.php#L254, and if you don't see the functions
 you need, we can either write them, or you can use our DB class
 https://buddypress.trac.wordpress.org/browser/tags/1.9.2/bp-notifications
 /bp-notifications-classes.php#L628

 Thanks for your work on this so far!

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5513#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac