[buddypress-trac] [BuddyPress] #5185: BP Signup - spaces in username issue

[buddypress-trac]

#5185: BP Signup - spaces in username issue
--------------------------------------------+---------------------------
 Reporter:  hnla                            |       Owner:  boonebgorges
     Type:  enhancement                     |      Status:  closed
 Priority:  normal                          |   Milestone:  1.9
Component:  Core                            |     Version:
 Severity:  normal                          |  Resolution:  fixed
 Keywords:  has-patch needs-testing commit  |
--------------------------------------------+---------------------------

Comment (by boonebgorges):

 >  I guess this is a good example of where if possible template tags need
 to be very generic e.g. 'bp_displayed_at_mention()' and changes fed into
 that from the core to prevent users having to edit their overloaded
 template files.

 Yes. And generally we try to do this. But the problem in this case was
 that the existing template tag in use referred directly to the nicename,
 which was *too specific*. So it needed to be changed.

 The problem you saw will only arise in the wild on an installation that
 (a) is running username compatibility mode *and* (b) is overriding the
 member-header.php template. This is a very small number of installations.
 And even in this case, it's only a display error - the "Public Message"
 button should still work correctly. So I don't think it's much to worry
 about.

 >  On a sidenote: noticed that checking the 5185-02 patch showed a
 previous version of the members-header template before that new template
 tag was introduced so guess that was committed after patch put up?

 A couple of commits happened to that line of the template in the interim.
 Check the logs for more details.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5185#comment:19>
BuddyPress <http://buddypress.org/>
BuddyPress