[buddypress-trac] [BuddyPress] #5014: Admin > Activity Stream Reply to Activity in Hidden Group Does Not Show up in Front End

[buddypress-trac]

#5014: Admin > Activity Stream Reply to Activity in Hidden Group Does Not Show up
in Front End
--------------------------+------------------
 Reporter:  mercime       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  high          |   Milestone:  1.9
Component:  Activity      |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+------------------
Changes (by boonebgorges):

 * priority:  normal => high
 * milestone:  1.8 => 1.9


Comment:

 I've confirmed the problem.

 The root issue is that the AJAX callback `bp_activity_admin_reply()` is
 using the incorrect values for `activity_id`. It's using the `root_id`
 params being passed in the AJAX request, which is in turn defined in
 `BP_Activity_List_Table::single_row()`
 http://buddypress.trac.wordpress.org/browser/tags/1.7.2/bp-activity/bp-
 activity-admin.php#L1110. The new activity comment is being created using
 the parent's item_id as the *reply's* root activity id, which is
 incorrect.

 It appears that this bug is actually breaking *all* activity replies, not
 just those in hidden groups. All replies created from the admin are being
 attached to the incorrect parent. It's just particularly noticeable in the
 case of hidden groups, because hidden group activity cannot be easily
 viewed elsewhere in the interface.

 It looks like the easiest fix is to modify the logic in `single_row()` so
 that the `data-root_id` attribute is set to `$item['id']` if the activity
 item is not an activity comment.

 But this needs testing, and the behavior described here is not a
 regression. I'm going to move it to 1.9.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5014#comment:2>
BuddyPress <http://buddypress.org/>
BuddyPress