[buddypress-trac] [BuddyPress] #4750: groups_screen_group_request_membership action is not called when group membership is requested

[buddypress-trac]

#4750: groups_screen_group_request_membership action is not called when group
membership is requested
--------------------------+-----------------------------
 Reporter:  rogercoathup  |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Core          |    Version:  1.7
 Severity:  normal        |   Keywords:
--------------------------+-----------------------------
 The do_action( 'groups_screen_group_request_membership' .. ) in the
 function groups_screen_group_request_membership() is in the wrong place in
 the code, and not called when group membership is requested:

 It needs to be moved inside the if ( isset( $_POST['group-request-send'] )
 clause, and called before the bp_core_redirect().

 Correct version of the function should be:


 function groups_screen_group_request_membership() {
         global $bp;

         if ( !is_user_logged_in() )
                 return false;

         $bp = buddypress();

         if ( 'private' != $bp->groups->current_group->status )
                 return false;

         // If the user has submitted a request, send it.
         if ( isset( $_POST['group-request-send']) ) {

                 // Check the nonce
                 if ( !check_admin_referer( 'groups_request_membership' ) )
                         return false;

                 if ( !groups_send_membership_request(
 bp_loggedin_user_id(), $bp->groups->current_group->id ) ) {
                         bp_core_add_message( __( 'There was an error
 sending your group membership request, please try again.', 'buddypress' ),
 'error' );
                 } else {
                         bp_core_add_message( __( 'Your membership request
 was sent to the group administrator successfully. You will be notified
 when the group administrator responds to your request.', 'buddypress' ) );
                 }
                 bp_core_redirect( bp_get_group_permalink(
 $bp->groups->current_group ) );
         }

         do_action( 'groups_screen_group_request_membership',
 $bp->groups->current_group->id );

         bp_core_load_template( apply_filters(
 'groups_template_group_request_membership', 'groups/single/home' ) );
 }

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4750>
BuddyPress <http://buddypress.org/>
BuddyPress