[buddypress-trac] [BuddyPress] #5300: Notifications from inactive components are rendered on the Notifications panel

buddypress-trac noreply at wordpress.org
Tue Dec 17 17:37:10 UTC 2013


#5300: Notifications from inactive components are rendered on the Notifications
panel
-----------------------------------+------------------------------
 Reporter:  boonebgorges           |       Owner:  johnjamesjacoby
     Type:  defect (bug)           |      Status:  closed
 Priority:  normal                 |   Milestone:  1.9.1
Component:  Notifications          |     Version:
 Severity:  normal                 |  Resolution:  fixed
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+------------------------------
Changes (by johnjamesjacoby):

 * owner:   => johnjamesjacoby
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"7686"]:
 {{{
 #!CommitTicketReference repository="" revision="7686"
 Notifications:

 Make `buddypress()->active_components` the default value for the
 `component_name` argument.

 This is necessary because notifications are persistent in the database,
 and active components register callbacks for generating output based on
 the queried results. If notifications exist for components that are
 inactive, no callback will be registered, and the output will be empty. By
 only querying for active components, we can be sure no empty notifications
 will be displayed to the user.

 Reverts r7677. See #5290. Fixes #5300. (trunk)
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5300#comment:9>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list