[buddypress-trac] [BuddyPress] #5300: Notifications from inactive components are rendered on the Notifications panel

buddypress-trac noreply at wordpress.org
Tue Dec 17 14:29:29 UTC 2013


#5300: Notifications from inactive components are rendered on the Notifications
panel
-----------------------------------+--------------------
 Reporter:  boonebgorges           |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  1.9.1
Component:  Notifications          |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+--------------------

Comment (by johnjamesjacoby):

 I'd rather not introduce a possibly temporary switch to handle something
 we can already do with a default parameter. I like the idea of having the
 default `component_name` value be active components only. That fixes the
 bug, maintains 1.9 arguments, and mimics the behavior of similar query
 methods in WordPress core.

 I agree that active VS inactive is a fairly clear designation that should
 be made, but since we can handle it transparently, in a smarter way that
 doesn't make it incredibly easy to override back to the buggered state,
 I'd rather we do it in a way that let's us slow roll API additions later.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5300#comment:5>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list