[buddypress-trac] [BuddyPress] #5155: Messaging: ajax autocomplete does not work if users want to send an email to users login name

[buddypress-trac]

#5155: Messaging: ajax autocomplete does not work if users want to send an email
to users login name
------------------------------------+------------------------------
 Reporter:  quan_flo                |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Core                    |     Version:  1.8.1
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+------------------------------

Comment (by boonebgorges):

 Autocomplete ajax appears to be the only place in BP where we use
 `BP_Core_User::search_users()`. Most search passes through
 `BP_User_Query`, and that'll take significant refactoring to search by
 $wpdb->users fields as well, as they're not currently joined (and,
 ideally, will not be joined).

 Since we're already doing the join in `BP_Core_User::search_users()`, the
 damage is already being done there, and I don't have a particular problem
 adding a search by user_nicename or user_login fields. However, it's going
 to create a disparity between this search and the main search in
 `BP_User_Query`. (You might further argue that we should refactor the
 autocomplete to use `BP_User_Query`, for less reduplication of code.)

 On balance, I guess my preference would be not to add more enhancements to
 `BP_Core_User::search_users()`. Instead, I'd suggest that we add
 functionality to search against $wpdb->users in `BP_User_Query`, and then
 switch the ajax over. More work, but a better end product.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5155#comment:2>
BuddyPress <http://buddypress.org/>
BuddyPress