[buddypress-trac] [BuddyPress] #4869: BP Theme Compat & BuddyPress Widgets styles

[buddypress-trac]

#4869: BP Theme Compat & BuddyPress Widgets styles
------------------------------------+-----------------------
 Reporter:  imath                   |       Owner:
     Type:  enhancement             |      Status:  reopened
 Priority:  normal                  |   Milestone:  1.8
Component:  Theme                   |     Version:  1.7
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+-----------------------

Comment (by r-a-y):

 imath did some great work in his original patch; however, in the CSS, we
 make assumptions that every theme will use a `widget` class.

 That is not always the case.  For example, TwentyTen uses the `widget-
 container` class instead of `widget`.  Therefore, the widget styles will
 not apply.

 The widget JS will also fail because the JS explicitly depends on the
 `widget` class:
 https://buddypress.trac.wordpress.org/browser/tags/1.7-rc1/bp-core/js
 /widget-members.js#L2

 In 03.patch, I've wrapped all BP widgets with `<div class="widget
 buddypress">`.  This is so imath's CSS will still work and most
 importantly, BP's widget JS is able to pick up the widget filter.  I've
 also tweaked the CSS a tiny bit.

 We should look at adding this back into the 1.7 milestone.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4869#comment:22>
BuddyPress <http://buddypress.org/>
BuddyPress