[buddypress-trac] [BuddyPress] #4533: Avoid "Notice: Undefined index" in bp_core_remove_nav_item

[buddypress-trac at lists.automattic.com]

#4533: Avoid "Notice: Undefined index" in bp_core_remove_nav_item
--------------------------+-----------------------
 Reporter:  wpdennis      |       Owner:
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  1.7
Component:  Core          |     Version:
 Severity:  trivial       |  Resolution:
 Keywords:  dev-feedback  |
--------------------------+-----------------------

Comment (by wpdennis):

 Replying to [comment:1 boonebgorges]:
 > Great suggestion. We should actually return false (or maybe an error) so
 that plugin authors can get an appropriate response.

 Thanks for your feedback.

 Returning false would be even better than returning void. I would prefer
 false over an error, because it seems to be more consistent to me
 (bp_core_new_nav_item, bp_core_sort_nav_items & Co).

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4533#comment:3>
BuddyPress <http://buddypress.org/>
BuddyPress