[buddypress-trac] [BuddyPress] #4218: Disabling activation email with bp_core_signup_send_activation_key breaks the signup

[buddypress-trac at lists.automattic.com]

#4218: Disabling activation email with bp_core_signup_send_activation_key breaks
the signup
--------------------------+-----------------------------
 Reporter:  boonebgorges  |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Core          |    Version:
 Severity:  normal        |   Keywords:
--------------------------+-----------------------------
 See https://buddypress.trac.wordpress.org/browser/trunk/bp-members/bp-
 members-functions.php#L1098

 If you filter 'bp_core_signup_send_validation_email' and return false, an
 activation key is never generated for the user in question. As a result,
 you end up with an unactivated user, but no key that you can feed to
 bp_core_activate_signup().

 A quick is just to move the generation of the activation_key outside of
 the conditional. Then, at least, the filter will be doing what it claims
 to be doing: namely, to disable the activation *email* rather than the
 generation of a key. However, this may pose problems for backward
 compatibility. Thoughts?

 See also #3443.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4218>
BuddyPress <http://buddypress.org/>
BuddyPress