[buddypress-trac] [BuddyPress] #4182: Duplicate group invitations cannot be cleared

buddypress-trac at lists.automattic.com buddypress-trac at lists.automattic.com
Thu May 3 14:31:28 UTC 2012


#4182: Duplicate group invitations cannot be cleared
--------------------------+-----------------
 Reporter:  boonebgorges  |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  1.6
Component:  Core          |    Version:
 Severity:  normal        |   Keywords:
--------------------------+-----------------
 In the past (I think not anymore, but who knows?), BuddyPress was a little
 sloppy about cleaning up multiple group membership requests/invitations.
 So sometimes you would be invited to a group that you had previously
 requested membership in, and when membership was approved, the invitation
 was not also marked as accepted (or deleted). The result is that you have
 a group invitation that cannot be accepted, because the first thing BP
 does in `groups_accept_invite()` is to check whether the user is already a
 member, and if so return false.

 Better behavior would be: If the user is already a member of the group,
 then delete all outstanding requests/invitations, and return *true*, since
 the state of affairs being requested - to be a member of the group -
 actually obtains.

 Note that this doesn't prevent the problem from happening in the first
 place, but (a) I think that the source of the problem has been solved
 elsewhere, and (b) it doesn't hurt to be redundant in this case.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4182>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list