[buddypress-trac] [BuddyPress] #4245: Improve authentication routine

[buddypress-trac at lists.automattic.com]

#4245: Improve authentication routine
--------------------------+-----------------------------
 Reporter:  r-a-y         |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Members       |    Version:  1.5
 Severity:  normal        |   Keywords:  has-patch
--------------------------+-----------------------------
 In bp_core_signup_disable_inactive() and bp_core_boot_spammer(), checks
 are done against the `$username` parameter.

 This isn't necessary; we should just use the passed `$auth_obj` and do
 checks against that as some plugins might already take advantage of the
 'authenticate' filter and the `$auth_obj` variable (like the WP Email
 Login plugin).

 (This ticket was created because of [http://wordpress.org/support/topic
 /plugin-wp-email-login-this-plugin-allows-non-activated-users-to-
 login?replies=1 an issue with BuddyPress and the WP Email Login plugin].)

 In the attached patch, I have renamed `$auth_obj` to `$user`, changed the
 authentication logic and cleaned up the PHPDoc for these two functions.

 Let me know if you guys have any Qs!

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4245>
BuddyPress <http://buddypress.org/>
BuddyPress