[buddypress-trac] [BuddyPress] #3595: Menu still not working with 1.5 and IE7

[buddypress-trac at lists.automattic.com]

#3595: Menu still not working with 1.5 and IE7
------------------------------------+------------------
 Reporter:  blogsterfiles           |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  1.6
Component:  Theme                   |     Version:  1.5
 Severity:  major                   |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+------------------
Changes (by hnla):

 * keywords:  has-patch => has-patch dev-feedback


Comment:

 Your patch .03 provides best solution, if inline-block was required then
 the correct approach would be to add a CC sheet for IE and setting
 display: inline - not hugely easy with WP - given the issue changing to
 'float' is the best solution.



 * 'display: inline-block;' is largely redundant on the li elements now,
 however it is a trigger for the MS construct hasLayout forcing it to '=
 true' which will then act to contain floats so may be left in place at no
 particular cost.

 * For safety font-size: 0; line-height:0; ought to be added to that pseudo
 element to ensure no browsers try and preserve line-height/height for the
 element. There is an updated approach to the time honoured 'clearfix'
 approach which uses the display:table property to effect clearing and is
 somewhat lighter in properties required.

 * While true that IE7 =< 7 does not grok pseudo element :after float
 containment is provided for on the parent #navigation element due to it
 having a stated dimension 'width' which is a 'hasLayout = true' trigger.

 I would add this patch and close ticket.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3595#comment:25>
BuddyPress <http://buddypress.org/>
BuddyPress