[buddypress-trac] [BuddyPress] #4480: Namespace class names

buddypress-trac at lists.automattic.com buddypress-trac at lists.automattic.com
Tue Aug 28 17:21:44 UTC 2012


#4480: Namespace class names
--------------------------+-----------------------------
 Reporter:  rogercoathup  |      Owner:
     Type:  enhancement   |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Core          |    Version:
 Severity:  normal        |   Keywords:
--------------------------+-----------------------------
 Class names (particularly those to which BP is attaching JS functions to
 generate UI) should be name spaced.
 Generic class names like 'confirm' are getting UI elements attached to
 them in core BP code.

 This is wrong!  Front end developers should be able to use generic
 classnames without BP introducing unexpected UI elements.

 Details of one example:

 BP automatically adds a dialog box confirmation to any <a> tag to which
 the class 'confirm' is added.  This is done in bp-core/bp-corecssjs.php --
 function: bp_core_confirmation_js()


 To fix this - generic classnames that BP is attaching UI elements to
 (particularly via core javascripts)  should be namespaced.

 i.e. use classnames such as 'bp-confirm' instead of 'confirm'

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4480>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list