[buddypress-trac] [BuddyPress] #4215: bp_core_fetch_avatar html pref checking should use !empty

buddypress-trac at lists.automattic.com buddypress-trac at lists.automattic.com
Wed Aug 8 16:38:09 UTC 2012


#4215: bp_core_fetch_avatar html pref checking should use !empty
-------------------------+-----------------------
 Reporter:  magnus78     |       Owner:
     Type:  enhancement  |      Status:  reopened
 Priority:  normal       |   Milestone:  1.6.1
Component:  Core         |     Version:
 Severity:  critical     |  Resolution:
 Keywords:  has-patch    |
-------------------------+-----------------------

Comment (by boonebgorges):

 (In [6246]) Do a strict type check for 'html' parameter in
 bp_core_fetch_avatar()

 In r6046, the type check was loosened, to make it somewhat easier for
 themers
 to pass a false value for 'html'. However, it was found after the 1.6
 release
 that this change broke backward compatibility with certain ways of calling
 bp_core_fetch_avatar(). See #4215 for info on the original change.

 Fixes #6046

 Props rogercoathup

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4215#comment:7>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list