[buddypress-trac] [BuddyPress] #3985: Race condition processing Ajax requests.

[buddypress-trac at lists.automattic.com]

#3985: Race condition processing Ajax requests.
----------------------------------------+-----------------------
 Reporter:  gary_mazz                   |       Owner:  DJPaul
     Type:  defect (bug)                |      Status:  assigned
 Priority:  normal                      |   Milestone:  1.6
Component:  Core                        |     Version:  1.5.3
 Severity:  major                       |  Resolution:
 Keywords:  dev-feedback needs-testing  |
----------------------------------------+-----------------------
Changes (by DJPaul):

 * keywords:  dev-feedback => dev-feedback needs-testing


Comment:

 First attempt at a patch attached (3985-01.patch). Please test on default
 theme in trunk, and on child themes inheriting Default's ajax.php (e.g.
 Status theme), and on themes that include a copy of the old ajax.php.
 Please also test on bug reported in this ticket (custom taxonomy problem).

 A key difference is that admin-ajax.php always returns "0" at the end of
 output, unless the AJAX handler terminates script execution, e.g. exit().
 This caused breakage in a lot of places because all the return values had
 "0" suffixed to them; in some places this was visible and/or broke things.

 There was and still is a mismatch of all different sorts of return types
 in ajax.php, and with the intention of not breaking backpat or requiring
 sizeable updates to BP-Default's javascript, I've kept things as simple as
 possible. Suffice to say, I'm looking forward to 1.7 when we can re-build
 all of this from scratch.
 ---


 Resolve problems with load order when handling AJAX requests in
 BuddyPress.
 * Reworks BP-Default's AJAX calls to use correct receiver in WordPress.
 * Hooks BP-Default's AJAX handlers to both 'wp_ajax_nopriv_' and
 'wp_ajax'.
 * Updates associated parts in BP core to support this, and deprecates old
 handling.
 * Renames Activity spam/unspam AJAX actions (new to BP 1.6).
 * Adds full PHPDoc to ajax.php.
 * Code standards pass of ajax.php.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3985#comment:13>
BuddyPress <http://buddypress.org/>
BuddyPress