[buddypress-trac] [BuddyPress] #3539: Group forum stickies are ignored when queried with AJAX

[buddypress-trac at lists.automattic.com]

#3539: Group forum stickies are ignored when queried with AJAX
-------------------------------------------------+------------------
 Reporter:  boonebgorges                         |       Owner:
     Type:  defect                               |      Status:  new
 Priority:  normal                               |   Milestone:  1.5
Component:  Forums                               |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing 2nd-opinion  |
-------------------------------------------------+------------------
Changes (by boonebgorges):

 * keywords:   => has-patch needs-testing 2nd-opinion


Comment:

 This ended up being a deeper problem than I thought. Essentially, it boils
 down to the fact that the bp-forums-scope cookie is being set incorrectly.
 It is set, through a somewhat convoluted process, according to the CSS
 classes of the group forum navigation tabs. More specifically, because the
 options_nav was being constructed so that the tabs had the class 'forums-
 personal-li', the scope cookie was being set as 'personal'. This seems
 like an oversight to me: those navigation tabs should have the class
 .forums-groups-li when looking at a group. See 3539.01.patch. (The patch
 also contains a minor fix that passes some missing parameters along the
 bp_has_forum_topics() path - it's not a vital part of the patch.)

 I want to get a second opinion about this. I am pretty certain that I've
 correctly identified the problem, but I want some feedback regarding the
 wisdom of changing these classes. The concern with changing selectors is
 that it will break styling and/or javascript in some child themes. It
 didn't actually break or change anything in bp-default, so I think it's
 pretty unlikely that there will be many issues, but it's a possibility.
 Anyone else care to chime in on this?

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3539#comment:1>
BuddyPress <http://buddypress.org/>
BuddyPress