[buddypress-trac] [BuddyPress] #3389: Enqueueing CSS of bp-default breaks child theme layouts

[buddypress-trac at lists.automattic.com]

#3389: Enqueueing CSS of bp-default breaks child theme layouts
-----------------------+------------------
 Reporter:  mercime    |       Owner:
     Type:  defect     |      Status:  new
 Priority:  normal     |   Milestone:  1.5
Component:  Theme      |     Version:
 Severity:  normal     |  Resolution:
 Keywords:  has-patch  |
-----------------------+------------------

Comment (by r-a-y):

 Replying to [comment:43 boonebgorges]:
 > > The problem with this approach is this assumes that the child theme's
 stylesheet uses an @import rule... This also doesn't solve the problem of
 child themes that have the stylesheet hardcoded in header.php.
 >
 > If by the first sentence you mean the same thing that you say in the
 second sentence, then yes. If you mean that my solution doesn't account
 for people using @import, I don't understand - I have regex for that very
 purpose.

 I do mean the same thing! Sorry for the confusion!

 ---

 > If a newer theme plugins bp_dtheme_enqueue_styles(), then they will be
 responsible for registering bp-default's CSS. I think that's reasonable.
 Anyone who plugs the function will know what they're doing, or at least
 they should if they're doing the plugging.

 Yeah, I believe you're right!

 The child theme would have to remove the 'get_header' hook for ob_start()
 as well by either overriding bp_dtheme_setup() or using remove_action().

 That being said, I'm not really fond of the idea of using ob_start() in a
 theme, ya know?  If this approach is implemented, hopefully we can remove
 this in v1.6.

 Might want to get JJJ and pgibbs' take on things.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3389#comment:44>
BuddyPress <http://buddypress.org/>
BuddyPress