[buddypress-trac] [BuddyPress] #3389: Enqueueing CSS of bp-default breaks child theme layouts

[buddypress-trac at lists.automattic.com]

#3389: Enqueueing CSS of bp-default breaks child theme layouts
-----------------------+------------------
 Reporter:  mercime    |       Owner:
     Type:  defect     |      Status:  new
 Priority:  normal     |   Milestone:  1.5
Component:  Theme      |     Version:
 Severity:  normal     |  Resolution:
 Keywords:  has-patch  |
-----------------------+------------------

Comment (by boonebgorges):

 > The problem with this approach is this assumes that the child theme's
 stylesheet uses an @import rule... This also doesn't solve the problem of
 child themes that have the stylesheet hardcoded in header.php.

 If by the first sentence you mean the same thing that you say in the
 second sentence, then yes. If you mean that my solution doesn't account
 for people using @import, I don't understand - I have regex for that very
 purpose.

 That said, your solution is more foolproof, because it does look for
 hardcoded links to the stylesheet. That seems to be the main advantage of
 using ob_start() rather than opening the files with file_get_contents().

 If a newer theme plugins bp_dtheme_enqueue_styles(), then they will be
 responsible for registering bp-default's CSS. I think that's reasonable.
 Anyone who plugs the function will know what they're doing, or at least
 they should if they're doing the plugging.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3389#comment:43>
BuddyPress <http://buddypress.org/>
BuddyPress