[buddypress-trac] [BuddyPress] #3695: Basic profile privacy

[buddypress-trac at lists.automattic.com]

#3695: Basic profile privacy
-----------------------------------------------+---------------------------
 Reporter:  boonebgorges                       |       Owner:  cnorris23
     Type:  enhancement                        |      Status:  accepted
 Priority:  normal                             |   Milestone:  Future
Component:  Core                               |  Release
 Severity:  normal                             |     Version:
 Keywords:  needs-patch dev-feedback needs-ui  |  Resolution:
-----------------------------------------------+---------------------------

Comment (by boonebgorges):

 Great start! Thanks for giving us something to work with. Some thoughts:

 1) For efficiency's sake, we should probably load privacy levels into
 $profile_template. Probably introduce some sort of
 get_profile_data_extras() method in BP_XProfile_ProfileData, along the
 lines of what we do in BP_Core_User. Then bp_profile_field_is_private()
 will try to get it from there first. Matters more on the public profile
 than on the edit page.

 2) Re: UI fields. I suggest dropping No One (having none checked would be
 the equivalent), and adding some JS that makes checking Everyone select
 the others, and deselecting any of the others uncheck Everyone.

 3) Might want to consider moving the per-field privacy options out from
 under the individual fields, and into a collapsible "privacy" section on
 the edit screen. Might make things less cluttered.

 4) Hiding fields as late in the game as you do (ie in the template itself)
 means that zebra-striping is broken. If we move up the chain a bit, either
 as a filter on bp_has_profile or in the query itself, we won't have this
 problem (though that is, of course, more complicated, and may interfere
 with my suggestion in (1) about $profile_template). For reference, see the
 way that bp_has_profile()'s show_empty_fields works.

 5) Something seems to be broken, so I'm getting errors when I save my
 profile; also, when I set privacy level for one field, it's getting
 applied to all the other fields being saved as well. Something to fix in
 the spit-n-shine :)

 Anyway, these are all initial thoughts from looking at the code for just a
 few minutes. Would like to hear more from cnorris23 and the other core
 devs.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3695#comment:4>
BuddyPress <http://buddypress.org/>
BuddyPress