[buddypress-trac] [BuddyPress] #3233: Cutdown the queries for Xprofile select/Multiselect field

buddypress-trac at lists.automattic.com buddypress-trac at lists.automattic.com
Sat May 21 14:04:33 UTC 2011


#3233: Cutdown the queries for Xprofile select/Multiselect field
--------------------------+-----------------------------
  Reporter:  sbrajesh     |      Owner:  sbrajesh
      Type:  enhancement  |     Status:  new
  Priority:  normal       |  Milestone:  Awaiting Review
 Component:  XProfile     |    Version:  1.3
Resolution:               |   Keywords:  has-patch
--------------------------+-----------------------------

Comment (by sbrajesh):

 If we look at the original code, that section of code does not do anything
 which will have any effect on working. I am sure, it is not affecting the
 security but a second opinon will be much better. My main goal was putting

 {{{
 $original_option_values = maybe_unserialize(
 BP_XProfile_ProfileData::get_value_byid( $options[$k]->parent_id ) );
 }}}

 outside the loop as it actually called the same thing every time. Please
 do test and let me know if we can improve further.
 btw, we can do something similar for the checkboxes too(I really did not
 test the number of queries for checkboxses earlier, but seeing code, that
 seems also another candidate for change).

-- 
Ticket URL: <https://trac.buddypress.org/ticket/3233#comment:2>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list