[buddypress-trac] [BuddyPress] #2707: Support oembed

[buddypress-trac at lists.automattic.com]

#2707: Support oembed
---------------------+------------------------------------
  Reporter:  DJPaul  |      Owner:
      Type:  defect  |     Status:  new
  Priority:  major   |  Milestone:  1.3
 Component:  Core    |    Version:  1.3
Resolution:          |   Keywords:  has-patch dev-feedback
---------------------+------------------------------------
Changes (by r-a-y):

 * keywords:  has-patch needs-refresh dev-feedback => has-patch dev-feedback


Comment:

 2707.006.patch takes into consideration ticket #WP17857.
 If the WP patch is accepted, BP_Embed::shortcode() can be removed from a
 future BP release.

 I forgot to alter line 1173 of bp-core-classes.php in the patch to remove
 the author_can() check.  Though, this does bring up an interesting point.

 I think we should remove the author_can( $id, 'unfiltered_html' ) check
 for BP because unless you're a super admin,
 {{{
 $attr['discover']
 }}}
 will most likely always return false.  Thus, negating the usefulness of
 oEmbed discovery.

 However, WP_Embed::shortcode() has always had the author_can() check.  So
 if we remove BP_Embed::shortcode() in the future, we'll likely to face the
 same problem as the majority of users will not have the 'unfiltered_html'
 cap.

 Thoughts?

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/2707#comment:16>
BuddyPress <http://buddypress.org/>
BuddyPress