[buddypress-trac] [BuddyPress] #3418: Probable Inconsistency in the name of Actions created by BP_Component class

buddypress-trac at lists.automattic.com buddypress-trac at lists.automattic.com
Sat Jul 30 20:43:21 UTC 2011


#3418: Probable Inconsistency in the name of Actions created by BP_Component class
-------------------------+-----------------------------
 Reporter:  sbrajesh     |      Owner:
     Type:  enhancement  |     Status:  new
 Priority:  normal       |  Milestone:  Awaiting Review
Component:  Core         |    Version:  1.5
 Severity:  normal       |   Keywords:  has-patch
-------------------------+-----------------------------
 Hi Core Devs,
 First of all, I want to thank you all for the BP_Component class which
 takes a lot of pain(or may be writing code) out of the plugin development.
 It's a major improvement.

 I have found something which seems more like a typeo. Earlier we had
 actions like "bp_groups_setup_global" or so on in the format
 "bp_componentId_actionname", In bp 1.3, The BP_Component calls it like

 do_action( 'bp_' . $this->id . 'setup_globals' );
 That means, for group component, the setup global action will be
 "bp_groupssetup_globals" not the "bp_groups_setup_global".

 The same thing is for a few other actions in the class. Just wanted to
 know if it is intentional or some type in the core.

 Here is a patch attached to update that if you consider this change
 worthy.

 Thanks.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3418>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list