[buddypress-trac] [BuddyPress] #3500: Get correct avatar thumbnail size in single activity view

buddypress-trac at lists.automattic.com buddypress-trac at lists.automattic.com
Sat Aug 20 13:22:47 UTC 2011


#3500: Get correct avatar thumbnail size in single activity view
-----------------------+------------------
 Reporter:  Jonnyauk   |       Owner:
     Type:  defect     |      Status:  new
 Priority:  minor      |   Milestone:  1.5
Component:  Activity   |     Version:
 Severity:  minor      |  Resolution:
 Keywords:  has-patch  |
-----------------------+------------------
Changes (by boonebgorges):

 * priority:  normal => minor
 * component:  Core => Activity
 * severity:  normal => minor
 * milestone:  Awaiting Review => 1.5


Comment:

 Good call. This is definitely a bug.

 It seems to me that the check for 'thumb' == $type &&
 bp_is_single_activity() is a hack. If we want a full avatar, we should
 request it. I've attached 3500.02.patch, which has what is, IMO, a better
 solution (it sets an intelligent default, and removes the argument from
 the template). Just need someone to glance at it and make sure it won't
 break existing themes. I'm pretty sure it will be backward compatible.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3500#comment:1>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list