[buddypress-trac] [BuddyPress] #3389: Enqueueing CSS of bp-default breaks child theme layouts

buddypress-trac at lists.automattic.com buddypress-trac at lists.automattic.com
Tue Aug 16 11:49:24 UTC 2011


#3389: Enqueueing CSS of bp-default breaks child theme layouts
---------------------+------------------------------
 Reporter:  mercime  |       Owner:
     Type:  defect   |      Status:  new
 Priority:  normal   |   Milestone:  Awaiting Review
Component:  Theme    |     Version:  1.5
 Severity:  normal   |  Resolution:
 Keywords:           |
---------------------+------------------------------

Comment (by boonebgorges):

 > The admin bar CSS should never have been included in DTheme, which is
 why it was moved out.

 Agreed. This makes sense. (Though it will make it tricky to override admin
 bar CSS in one's theme. You'll have to enqueue an extra stylesheet to be
 dependent on bp's admin bar CSS.)

 I don't have a problem per se with bp-default's stylesheet being enqueued.
 The pluggable method seems fine to me. We just need to be extremely clear
 in the documentation about it, since it seems to me (as someone who
 doesn't work much with WP themes - I may be wrong about this) that this
 behavior is not standard; I've never seen a theme that has an
 intentionally blank style.css in favor of enqueuing. (I can see why this
 standard would be nice, though.)

 3389.01.patch has some suggested wording for the inline docs. The BP codex
 page should be updated tout de suite with a section about this as well.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3389#comment:18>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list