[buddypress-trac] [BuddyPress] #3468: Simplifying Default Theme Structure

buddypress-trac at lists.automattic.com buddypress-trac at lists.automattic.com
Wed Aug 10 17:40:57 UTC 2011


#3468: Simplifying Default Theme Structure
-----------------------------+-----------------------------
 Reporter:  alanchrishughes  |       Owner:
     Type:  enhancement      |      Status:  new
 Priority:  normal           |   Milestone:  Future Release
Component:  Theme            |     Version:
 Severity:  normal           |  Resolution:
 Keywords:                   |
-----------------------------+-----------------------------

Comment (by boonebgorges):

 I'm afraid I still don't understand what you're getting at. bp-default has
 a partially dynamic-width theme. #content is set as a percentage of
 #container http://buddypress.trac.wordpress.org/browser/trunk/bp-themes
 /bp-default/_inc/css/default.css#L103 which is, in turn, a percentage of
 body http://buddypress.trac.wordpress.org/browser/trunk/bp-themes/bp-
 default/_inc/css/default.css#L103, which is partially dynamic
 http://buddypress.trac.wordpress.org/browser/trunk/bp-themes/bp-
 default/_inc/css/default.css#L66 If we hardcode the width, it'll no longer
 be dynamic.

 The width of #sidebar is set here:
 http://buddypress.trac.wordpress.org/browser/trunk/bp-themes/bp-
 default/_inc/css/default.css#L246

 bp-default does not use a #page selector, so your #page suggestion would
 do nothing.

 By "trunk version", I mean the latest development version of BuddyPress.
 You can browse it here http://buddypress.trac.wordpress.org/browser or
 download it here
 http://buddypress.trac.wordpress.org/changeset/4964/trunk?old_path=%2F&format=zip

 I may be misunderstanding what you're saying. If you're suggesting that
 the markup itself be simplified, you'll have to provide specific examples
 of where they should change. Or if you're saying that dynamic width is a
 bad thing, you should say that. Or if you're just unhappy that we use so
 many CSS declarations, then I'm afraid I don't know what to say - that's
 just how bp-default is built. As I say in my previous comment, most modern
 WP themes have a relatively complex markup structure, which requires more
 than minimal CSS to look good across browsers.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3468#comment:3>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list