[buddypress-trac] [BuddyPress] #3447: Audit use of extract( $r, EXTR_SKIP )

[buddypress-trac at lists.automattic.com]

#3447: Audit use of extract( $r, EXTR_SKIP )
------------------------+------------------
 Reporter:  dontdream   |       Owner:
     Type:  defect      |      Status:  new
 Priority:  normal      |   Milestone:  1.5
Component:  Core        |     Version:  1.5
 Severity:  normal      |  Resolution:
 Keywords:              |
------------------------+------------------

Comment (by boonebgorges):

 When you set the default with a value like $hide_empty_fields, and then
 use extract( $r, EXTR_SKIP );, $r['hide_empty_fields'] will not be
 extracted, but $hide_empty_fields will retain its previous value. If we
 leave out EXTR_SKIP, it's irrelevant - but in any case it seems like bad
 practice to use the same variable name, in the same function scope, for
 two different purposes.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3447#comment:10>
BuddyPress <http://buddypress.org/>
BuddyPress