[buddypress-trac] [BuddyPress] #2152: no way to retrieve group avatar from ID

buddypress-trac at lists.automattic.com buddypress-trac at lists.automattic.com
Mon Apr 11 21:36:34 UTC 2011


#2152: no way to retrieve group avatar from ID
--------------------------+-----------------------------
  Reporter:  mikepratt    |      Owner:  calvin_42
      Type:  enhancement  |     Status:  accepted
  Priority:  normal       |  Milestone:  Awaiting Review
 Component:  Groups       |    Version:  1.2
Resolution:               |   Keywords:
--------------------------+-----------------------------

Comment (by boonebgorges):

 {{{
 I don't see why bp_displayed_user_avatar() or bp_loggedin_user_avatar()
 would need an $id parameter.
 }}}

 Agreed - was anyone suggesting that?

 There's a sense in which it would be quite nice for all template tags to
 have this feature, and technically there's no reason why it couldn't be
 done. I should note that WP itself is a mixed bag here; get_the_title()
 takes an optional $id, while get_the_content() does not.

 We should be consistent, though. So that means we need a good reason for
 deciding one way or the other. One argument for rejecting the proposal (to
 make template tags usable outside the loop) is that such a change might
 encourage inefficiency. The loops are (supposed to be) optimized,
 minimizing the number of DB calls. If every template tag allows you to
 make independent queries, you could get unconscientious developers
 building slow sites and then blaming it on BP.

-- 
Ticket URL: <https://trac.buddypress.org/ticket/2152#comment:6>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list