[buddypress-trac] [BuddyPress] #2644: bp_core_remove_nav_item(‘groups’) removes access to groups, not just navigation

[buddypress-trac at lists.automattic.com]

#2644: bp_core_remove_nav_item(‘groups’) removes access to groups, not just
navigation
----------------------------+-----------------------------------------------
 Reporter:  youngmicroserf  |       Owner:                                  
     Type:  defect          |      Status:  new                             
 Priority:  major           |   Milestone:  1.2.6                           
Component:  Core            |    Keywords:  [needs-patch] navigation rewrite
----------------------------+-----------------------------------------------
Changes (by boonebgorges):

 * cc: boonebgorges@… (added)


Comment:

 I've noticed this before too. I always thought it was a bit funny that
 bp_core_new_nav_item(), which sounds like it's just about navigation, is
 also the only place where the screen_function for that particular tab is
 ever referenced.

 JJJ, an alternative approach to your suggestion is to add a parameter to
 bp_core_new_nav_item(), something like 'show_in_nav', which defaults to
 true. Then, if someone wants to remove the nav item but not access to the
 page, then can use bp_core_remove_nav_item() and then readd it using
 show_in_nav = false. This is a little clunky, but it has the advantage of
 not making major changes to the $bp global in a dot-dot release.

-- 
Ticket URL: <http://trac.buddypress.org/ticket/2644#comment:5>
BuddyPress <http://buddypress.org/>
BuddyPress