[buddypress-trac] [BuddyPress] #2755: Remove deactivation hook

[buddypress-trac at lists.automattic.com]

#2755: Remove deactivation hook
--------------------------+-------------------------------------------------
 Reporter:  boonebgorges  |       Owner:     
     Type:  defect        |      Status:  new
 Priority:  major         |   Milestone:  1.3
Component:  Core          |     Version:     
 Keywords:                |  
--------------------------+-------------------------------------------------
 BP's deactivation hook bp_loader_deactivate() (bp-loader.php) deletes a
 bunch of live site options. This is a Bad Idea, especially because plugins
 often have to be deactivated for testing and maintenance (and upgrades!).

 Three options:
 1) Remove the deactivation hook altogether
 2) Leave it, but modify it from removing site options that are still valid
 3) Leave it, but just for the do_action() hook.

 My vote is for option (3). There might still be reasons why some other
 plugin would want to hook to BP activation, so it's worth it to keep the
 hook. The removal of stale settings should be done by proper upgrade
 routines like the one in bp-core-upgrade.php (in case someone wants to
 deactivate/activate without updating).

-- 
Ticket URL: <http://trac.buddypress.org/ticket/2755>
BuddyPress <http://buddypress.org/>
BuddyPress