[buddypress-trac] [BuddyPress] #2432: display multiple messages / notices via bp_core_render_message

buddypress-trac at lists.automattic.com buddypress-trac at lists.automattic.com
Sat Nov 6 19:47:30 UTC 2010


#2432: display multiple messages / notices via bp_core_render_message
-------------------------------+--------------------------------------------
 Reporter:  aesqe              |       Owner:     
     Type:  enhancement        |      Status:  new
 Priority:  normal             |   Milestone:  1.3
Component:  Core               |     Version:     
 Keywords:  notices, messages  |  
-------------------------------+--------------------------------------------

Comment(by boonebgorges):

 Thanks for the patch, aesqe.

 I reworked it a little bit. I think it's a great idea for BP to support
 multiple simultaneous template notices, but it doesn't seem urgent to me
 that bp_core_add_message() lets you add them in a single line. It ends up
 making the function a bit unwieldy, with all the is_array stuff.

 Instead, I've implemented the idea of a template_notice "stack", and when
 you call bp_core_add_message() it checks for the existence of the stack,
 and if it finds the stack, it adds the new message on top.

 It works really well on my installation, but I would like others to do a
 sanity check for me. I'm especially concerned about the base_64 encoding
 for cookies - I agree with aesqe that serialized cookies can be
 problematic, but this base_64 workaround is new to me. Again, it works
 well on Mac Chrome, Safari, and Firefox, but it'd be nice if it were run
 through a few other browsers too.

-- 
Ticket URL: <https://trac.buddypress.org/ticket/2432#comment:2>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list