[buddypress-trac] [BuddyPress] #2566: [patch] “Send Private Message” and “Mention this User” Button Filtering

[buddypress-trac at lists.automattic.com]

#2566: [patch] “Send Private Message” and “Mention this User” Button Filtering
-----------------------+----------------------------------------------------
 Reporter:  jeffsayre  |       Owner:  jeffsayre                                         
     Type:  defect     |      Status:  new                                               
 Priority:  major      |   Milestone:  1.2.6                                             
Component:  Core       |    Keywords:  has-patch, security, privacy, abstraction, filters
-----------------------+----------------------------------------------------

Comment(by jeffsayre):

 I respectfully disagree with your respectfully disagreeing!

 Actually, the only goal in this Trac ticket is to be able to control
 programmatically the outputted HTML. As it currently stands, that is only
 possible with the “Add Friend” button. So, whatever solution that is
 crafted must allow that flexibility.

 I do understand the desirability of making sure that template designers
 have easy access to the CSS selectors. It would be an easy addition to
 this currently proposed patch to add an additional filter that passes the
 CSS selectors separately from the rest of the HTML output.

 ''How would you feel about creating a general use template tag that can be
 passed parameters to check privacy settings against instead? We could
 extend the 'bp_user_has_access' function to be used through-out the
 template to allow/disallow functionality?''

 As an alternate way of providing button filtering, that is not a bad idea.
 I’m not sure that a general template tag will work for all instances--
 unless there are three to five parameters that can get passed. Why do I
 say this? Take a look at [http://trac.buddypress.org/ticket/2567 this Trac
 ticket].

 Just for the “Add Friend” button, three parameters need to be sent to make
 it possible for privacy filtering to occur in all of the places that the
 “Add Friend” button can show up. Two of these parameters are needed
 exclusively for this button. None of the other buttons require this
 elaborate of a check.

 As long as developers have programmatic access to filter out each of the
 buttons, the final solution does not matter. Of course, as mentioned
 above, sufficient parameters must be passed to allow for privacy filtering
 of the “Add Friend” button without having to go through elaborate
 programmatic gymnastics.

-- 
Ticket URL: <https://trac.buddypress.org/ticket/2566#comment:6>
BuddyPress <http://buddypress.org/>
BuddyPress